Re: [PATCH] PCI: rcar-gen4: Inline GIC_TRANSLATER offset macro

[Bjorn Helgaas]

On Fri, Jul 10, 2026 at 03:35:10PM +0200, Marek Vasut wrote:
> On 7/10/26 10:30 AM, Marc Zyngier wrote:
> > On Thu, 09 Jul 2026 21:10:03 +0100,
> > Marek Vasut <marek.vasut+renesas@xxxxxxxxxxx> wrote:
> > > 
> > > Instead of pulling in the whole linux/irqchip/arm-gic-v3.h ,
> > > copy the one GITS_TRANSLATER register offset macro directly into
> > > the driver.  This repairs the ability to build the driver on
> > > non-ARM non-GIC targets the way it was possible until now, which
> > > retains good build test coverage.
> ...

> So in the end, it is either this patch or limit the build to
> arm/arm64 . At least this patch still allows building this driver
> with more compilers on the various build bots, so I would opt for
> this patch here.

I like the build coverage, but duplicating the #define doesn't really
seem good to me.  It makes readability worse because cscope/tags now
sees two definitions without an obvious reason.