Re: [PATCH v3 0/5] minix: convert to iomap and add direct I/O

[Darrick J. Wong]

On Mon, Jul 13, 2026 at 12:26:27PM -0700, Jeremy Bingham wrote:
> On Mon, Jul 13, 2026 at 2:32 AM Christoph Hellwig <hch@xxxxxxxxxxxxx> wrote:
> >
> > On Sat, Jul 11, 2026 at 01:59:04PM -0700, Jeremy Bingham wrote:
> >
> > There's no point explaining each patch in the over letter, that's
> > what the commit log for each patch are for.
> 
> Understood. I've also read your other reply about how the cover letter
> and commits need to explain *why* rather than *how* and will fix
> them accordingly.
> 
> > How did you test this?  How do the xfstests auto group results look
> > with an without the series for minix?
> 
> I made a script that exercises about 40 different file and directory
> operations against each version of the minix filesystem. I tried running
> xfstests against minix with and without these patches, but it doesn't
> work under either case because mkfs.minix and fsck.minix don't take
> the expected arguments. I had backed off using xfstests for this
> because of that, but I'll revisit with the next round of changes.

Yes, please do get fstests working /before/ you start changing critical
file IO paths.

--D

> Thank you again for your comments,
> 
> -j