Re: [PATCH v6 2/3] pwm: rp1: Add RP1 PWM controller driver

[Andrea della Porta]

Hi Uwe,

On 19:05 Fri 03 Jul     , Andrea della Porta wrote:
> From: Naushir Patuck <naush@xxxxxxxxxxxxxxx>
> 
> The Raspberry Pi RP1 southbridge features an embedded PWM
> controller with 4 output channels, alongside an RPM interface
> to read the fan speed on the Raspberry Pi 5.
> 
> Add the supporting driver.
> 
> Signed-off-by: Naushir Patuck <naush@xxxxxxxxxxxxxxx>
> Co-developed-by: Stanimir Varbanov <svarbanov@xxxxxxx>
> Signed-off-by: Stanimir Varbanov <svarbanov@xxxxxxx>
> Signed-off-by: Andrea della Porta <andrea.porta@xxxxxxxx>
> ---
>  drivers/pwm/Kconfig   |   9 +
>  drivers/pwm/Makefile  |   1 +
>  drivers/pwm/pwm-rp1.c | 435 ++++++++++++++++++++++++++++++++++++++++++
>  3 files changed, 445 insertions(+)
>  create mode 100644 drivers/pwm/pwm-rp1.c
> 

<...snip...>

> +	.driver = {
> +		.name = "rp1-pwm",
> +		.of_match_table = rp1_pwm_of_match,
> +		.pm = pm_ptr(&rp1_pwm_pm_ops),
> +		.suppress_bind_attrs = true,
> +	},
> +};
> +builtin_platform_driver(rp1_pwm_driver);
> +
> +MODULE_DESCRIPTION("RP1 PWM driver");
> +MODULE_AUTHOR("Naushir Patuck <naush@xxxxxxxxxxxxxxx>");
> +MODULE_AUTHOR("Andrea della Porta <andrea.porta@xxxxxxxx>");
> +MODULE_LICENSE("GPL");
> -- 
> 2.35.3
>

I didn't get any feedback after I replied to Sashiko's latest concerns, which I
don't think are relevant. Can we proceed with this patch or are there other 
concerns about it?

Many thanks,
Andrea