Re: [PATCH v1] mm/damon: remove trailing semicolons after function definitions

From: SJ Park

Date: Tue Jul 14 2026 - 10:20:46 EST


On Tue, 14 Jul 2026 15:53:58 +0800 Xuewen Wang <wangxuewen@xxxxxxxxxx> wrote:

> Three function definitions terminate with '};' instead of '}',
> which is unnecessary and inconsistent with kernel coding style:
>
> - damon_pa_initcall() in paddr.c
> - damon_va_initcall() in vaddr.c
> - damos_get_some_mem_psi_total() in core.c
>
> No functional change intended.

Nice catch! Thank you for this patch!

>
> Signed-off-by: Xuewen Wang <wangxuewen@xxxxxxxxxx>

Reviewed-by: SJ Park <sj@xxxxxxxxxx>

This series is applied to damon/next [1] tree. If this series is not added to
mm.git in short term (~1 week?), I will ask mm.git maintainer (Andrew Morton)
to pick this. So, no action from your side is needed for now. If it seems I
also forgot doing that or you cannot wait for my action, please feel free to
directly ask that to Andrew.

[1] https://origin.kernel.org/doc/html/latest/mm/damon/maintainer-profile.html#scm-trees


Thanks,
SJ

[...]