Re: [PATCH v3] staging: greybus: uart: return tty_alloc_driver() errors

From: Dan Carpenter

Date: Tue Jul 14 2026 - 10:52:02 EST


On Tue, Jul 14, 2026 at 07:19:21PM +0530, Alfie Varghese wrote:
> gb_tty_init() maps any tty_alloc_driver() failure to -ENOMEM.
> tty_alloc_driver() currently always returns -ENOMEM on failure,
> so this does not change behavior in practice. However, returning
> PTR_ERR(gb_tty_driver) is more correct and consistent with kernel
> conventions, preserving any future error codes the function might
> return.
>
> Signed-off-by: Alfie Varghese <alfievarghese22@xxxxxxxxx>
> ---

Thanks!

Reviewed-by: Dan Carpenter <error27@xxxxxxxxx>

regards,
dan carpenter