Re: [PATCH v2] staging: media: meson: vdec: propagate devm_clk_get() errors
From: Dan Carpenter
Date: Tue Jul 14 2026 - 10:56:53 EST
On Tue, Jul 14, 2026 at 07:34:58PM +0530, Alfie Varghese wrote:
> vdec_probe() hardcodes -EPROBE_DEFER for all devm_clk_get() failures.
> This masks the actual error code returned by the clock framework, such
> as -ENOENT when a clock is not registered or -ENOMEM on allocation
> failure.
>
> Return PTR_ERR() instead to propagate the real error to the caller.
>
> Fixes: 4f75e7dfa6dc ("media: meson: vdec: add driver")
> Signed-off-by: Alfie Varghese <alfievarghese22@xxxxxxxxx>
> ---
Thanks!
Reviewed-by: Dan Carpenter <error27@xxxxxxxxx>
regards,
dan carpenter