Re: [PATCH v5 04/10] x86/resctrl: Attach ACPI ERDT information to L3 mon domain on CPU online

[Reinette Chatre]

Hi Chenyu,

On 7/14/26 1:51 AM, Chen, Yu C wrote:
> On 7/11/2026 7:45 AM, Reinette Chatre wrote:
>> On 7/1/26 6:45 AM, Chen Yu wrote:

...

>>> +     * otherwise this CPU should be isolated from resctrl.
>>> +     * For example, the hw_dom reports CPU{0,1} are in
>>> +     * l3 domain0, CPU{2,3} belongs to domain1. Meanwhile
>>
>> Please use consistent terms (l3 -> L3, cpumask -> cpu_mask, etc.)
>>
> 
> OK, will do.
> 
>>> +     * erdt_domain_info reports that CPU{0,2} are in domain0,
>>> +     * CPU{1,3} are in domain1. So when it comes to CPU1,
>>> +     * a mismatch is detected, we should remove CPU1 from
>>> +     * resctrl.
>>
>> CPU1 and CPU2?
>>
> 
> I think it should be CPU1 and CPU3 that will be removed from resctrl -
> because the first CPU of the hw_dom->cpumask will not find a mismatch per
> your description previously.

I expected that only the CPUs CPUID and ACPI disagree on will be removed?
In the example CPUID and ACPI agree on which domain CPU0 and CPU3 belongs to
while they disagree on which domain CPU1 and CPU2 belongs to. 

Reinette