Re: [PATCH 1/5] io_uring/fs: check unused sqe fields for unlinkat

[Gabriel Krisman Bertazi]

Yi Xie <xieyi@xxxxxxxxxx> writes:

> Zero check unused SQE fields addr3 and pad2 for unlinkat. They're
> not needed now, but could be used sometime in the future.
>
> Signed-off-by: Yi Xie <xieyi@xxxxxxxxxx>

Arguably, this is a common issue across many operations.  I'd love
to have a more automated way to write these checks.


Reviewed-by: Gabriel Krisman Bertazi <krisman@xxxxxxx>

> ---
>  io_uring/fs.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/io_uring/fs.c b/io_uring/fs.c
> index d0580c754bf8..26ea841a22e7 100644
> --- a/io_uring/fs.c
> +++ b/io_uring/fs.c
> @@ -110,7 +110,8 @@ int io_unlinkat_prep(struct io_kiocb *req, const struct io_uring_sqe *sqe)
>  	const char __user *fname;
>  	int err;
>  
> -	if (sqe->off || sqe->len || sqe->buf_index || sqe->splice_fd_in)
> +	if (sqe->off || sqe->len || sqe->buf_index || sqe->splice_fd_in ||
> +	    sqe->addr3 || sqe->__pad2[0])
>  		return -EINVAL;
>  	if (unlikely(req->flags & REQ_F_FIXED_FILE))
>  		return -EBADF;
> -- 
> 2.25.1
>

-- 
Gabriel Krisman Bertazi