Re: [PATCH v2 1/2] dt-bindings: iio: dac: Add DAC8163
From: David Lechner
Date: Tue Jul 14 2026 - 15:26:02 EST
On 7/14/26 11:49 AM, Conor Dooley wrote:
> On Tue, Jul 14, 2026 at 05:01:58PM +0200, Lukas wrote:
>> On Wed, Jul 08, 2026 at 05:37:44PM +0100, Conor Dooley wrote:
>>>> + clr-gpios:
>>>> + description:
>>>> + The device registers are reset when this pin is asserted. The output is
>>>> + set to zero (xxx2 devices) or mid-scale (xxx3 devices).
>>>> + maxItems: 1
>>>> +
>>>
>>> Sounds like this should be reset-gpios?
>>>
>>
>> Thanks for pointing this out. The description is actually wrong. The
>> datasheet says: "On activation of CLR, zero scale (DACxx62) or
>> mid-scale (DACxx63) is loaded to all input and DAC registers".
>> That means other registers are unaffected. I will update the description
>> but the clr-gpios is correct in this case i guess?
>
> Sounds about right.
For ad5791, we used clear-gpios for a pin with the same function
(even though the pin there is labeled CLR just like here).
So would be good to stick with that convention. (Same reason
we always use reset-gpios even when a pin is labeled RST, it
is the same function.)