Re: [RFC PATCH 06/22] memory: ti-ddrss: Add MR4 temperature-driven refresh rate driver

[Uwe Kleine-König]

Hello,

On Tue, Jul 14, 2026 at 06:25:57PM +0530, MANNURU VENKATESWARLU wrote:
> +#include <linux/mfd/ti-ddrss.h>
> +#include <linux/mod_devicetable.h>

Please drop this header. platform_device_id is provided by
<linux/platform_device.h>, so the explicit include isn't needed.

The mod_devicetable.h header will go away soon.

> +#include <linux/module.h>
> +#include <linux/platform_device.h>
> [...]
> +static const struct platform_device_id k3_ddr_mr4_id[] = {
> +	{ "ti-ddrss-mr4", 0 },
> +	{}
> +};

Please make this:

static const struct platform_device_id k3_ddr_mr4_id[] = {
	{ .name = "ti-ddrss-mr4" },
	{ }
};

> +MODULE_DEVICE_TABLE(platform, k3_ddr_mr4_id);
> +
> +static struct platform_driver k3_ddr_mr4_driver = {
> +	.driver = {
> +		.name		= "ti-ddrss-mr4",
> +		.dev_groups	= k3_ddr_mr4_groups,
> +	},
> +	.probe		= k3_ddr_mr4_probe,
> +	.id_table	= k3_ddr_mr4_id,

I'm not a fan of aligned `=`. These tend to diverge over time. And
sometimes they are not even aligned from the start ...
If you ask me, just use a single space before the `=`.

Best regards
Uwe

Attachment: signature.asc
Description: PGP signature