Re: [PATCH v2 2/4] cgroup/cpuset: update some comments about the page allocator
From: Zi Yan
Date: Tue Jul 14 2026 - 21:18:07 EST
On Tue Jul 14, 2026 at 5:32 AM EDT, Brendan Jackman wrote:
> These comments describing the page allocator are out of date:
>
> - __alloc_pages() is no longer a public API and has no business being
> described outside of mm/.
>
> - The `wait` variable is gone.
>
> It may be out of date for other reasons too but this patch is just
> fixing the issues that stood out.
>
> To fix it:
>
> - Instead of referring to a specific function, instead to "the page
> allocator"
>
> - Completely drop out-of-date details of that function's internal
> behaviour, since they were irrelevant anyway.
>
> Suggested-by: Zi Yan <ziy@xxxxxxxxxx>
> Link: https://lore.kernel.org/all/DJP11T5V7BDW.2FZZZ8R6LOY4I@xxxxxxxxxx/
> Signed-off-by: Brendan Jackman <jackmanb@xxxxxxxxxx>
> ---
> kernel/cgroup/cpuset.c | 13 +++++--------
> 1 file changed, 5 insertions(+), 8 deletions(-)
>
Thank you for updating the doc.
Reviewed-by: Zi Yan <ziy@xxxxxxxxxx>
--
Best Regards,
Yan, Zi