Re: [PATCH] counter: Remove redundant dev_err()/dev_err_probe()
From: PanChuang
Date: Tue Jul 14 2026 - 22:26:48 EST
On Mon, 13 Jul 2026 22:12:00 +0800, Joshua Crofts wrote:
On Mon, 13 Jul 2026 21:10:04 +0800
Pan Chuang <panchuang@xxxxxxxx> wrote:
Since commit 55b48e23f5c4 ("genirq/devres: Add error handling inI think you can drop the commit hash and title from the message.
devm_request_*_irq()"), devm_request_irq() and devm_request_threaded_irq()
automatically log detailed error messages on failure. Remove the
now-redundant driver-specific dev_err() and dev_err_probe() calls.
Signed-off-by: Pan Chuang <panchuang@xxxxxxxx>
---
Otherwise LGTM.
Reviewed-by: Joshua Crofts <joshua.crofts1@xxxxxxxxx>
Will drop the commit hash/title in v2. Thanks for the review!
Best regards,
PanChuang