Re: [PATCH v6 0/2] PM: dpm_watchdog: Improve DPM watchdog configurability
From: Tzung-Bi Shih
Date: Tue Jul 14 2026 - 23:38:53 EST
On Wed, Jul 08, 2026 at 04:33:15AM +0000, Tzung-Bi Shih wrote:
> This series improves the configurability of the DPM watchdog.
>
> Currently, the DPM watchdog is always enabled if compiled in. Also, the
> module parameters defined in drivers/base/power/main.c use the generic
> and non-descriptive "main" prefix.
>
> This series addresses these limitations.
>
> Patch 1 renames the module parameter prefix for
> drivers/base/power/main.c from "main" to "pm".
>
> Patch 2 introduces the "dpm_watchdog_enabled" module parameter to allow
> enabling/disabling the watchdog at boot time and runtime. It also adds
> CONFIG_DPM_WATCHDOG_ENABLED to set the default value of the module
> parameter at compile time.
>
> The primary motivation for this configurability revolves around Android
> GKI (Generic Kernel Image). We want to enable CONFIG_DPM_WATCHDOG in
> the GKI so the feature is available. However, because the GKI is shared
> across many different devices, we don't want to inadvertently affect
> devices that are unaware of this feature. This provides a way to
> compile it in, but keep it disabled by default for those devices via the
> kernel command line or module parameters.
>
> To maintain backward compatibility, CONFIG_DPM_WATCHDOG_ENABLED relies
> on `default y`. Previously, the DPM watchdog was always active if
> CONFIG_DPM_WATCHDOG was set. Defaulting this new option to 'y' ensures
> that the behavior remains unchanged for existing users and defconfigs
> when they upgrade.
> ---
> v6:
> - Change the prefix "pm_sleep" -> "pm".
>
> v5: https://lore.kernel.org/all/20260701045640.3130090-1-tzungbi@xxxxxxxxxx
> - Rebase to v7.2-rc1.
> - Fix Signed-off-by lines.
Since there was no further feedback on v5, I'm sending out v6. Any feedback
would be appreciated.