Re: [PATCH 3/3] memory: fsl_ifc: Use devm_request_irq and simplify remove
From: Krzysztof Kozlowski
Date: Wed Jul 15 2026 - 00:35:49 EST
On 14/07/2026 22:44, Rosen Penev wrote:
> On Thu, Jul 9, 2026 at 12:11 AM Krzysztof Kozlowski <krzk@xxxxxxxxxx> wrote:
>>
>> On 08/07/2026 21:37, Rosen Penev wrote:
>>> On Wed, Jul 8, 2026 at 4:04 AM Krzysztof Kozlowski <krzk@xxxxxxxxxx> wrote:
>>>>
>>>> On 04/06/2026 06:28, Rosen Penev wrote:
>>>>> -
>>>>> -err_free_nandirq:
>>>>> - if (fsl_ifc_ctrl_dev->nand_irq > 0)
>>>>> - free_irq(fsl_ifc_ctrl_dev->nand_irq, fsl_ifc_ctrl_dev);
>>>>> -err_free_irq:
>>>>> - free_irq(fsl_ifc_ctrl_dev->irq, fsl_ifc_ctrl_dev);
>>>>> - return ret;
>>>>> + return of_platform_default_populate(dev->dev.of_node, NULL, &dev->dev);
>>>>
>>>> This can be devm as well, in this patch.
>>> Not sure I follow.
>>
>> Use devm resource managed variant.
> What's the devm version of of_platform_default_populate?
Indeed, "default" variant does not have a devm. Patch is fine.
Best regards,
Krzysztof