Re: [RFC PATCH 03/22] dt-bindings: memory: ti,j721s2-msmc: Add TI K3 MSMC binding

[Krzysztof Kozlowski]

On 14/07/2026 14:55, MANNURU VENKATESWARLU wrote:
> +required:
> +  - compatible
> +  - '#address-cells'
> +  - '#size-cells'
> +  - ranges
> +
> +additionalProperties: false
> +
> +examples:
> +  - |
> +    #include <dt-bindings/interrupt-controller/arm-gic.h>
> +    #include <dt-bindings/soc/ti,sci_pm_domain.h>
> +
> +    msmc0: msmc {
> +        compatible = "ti,j721s2-msmc", "simple-bus";

NAK

> +        #address-cells = <2>;
> +        #size-cells = <2>;
> +        ranges;
> +        intrlv-gran = <0>;
> +        intrlv-size = <0>;
> +        ecc-enable  = <0>;
> +        emif-config = <0>;
> +        emif-active = <0>;

I do not accept downstream code sent to review.

Start doing proper internal reviews. This binding and DTS is absolutely
unacceptable, you just repeat all known mistakes ignoring any guidelines.

Best regards,
Krzysztof