Re: [PATCH] hte: Remove redundant dev_err()

[Mikko Perttunen]

On Monday, July 13, 2026 10:29 PM Pan Chuang wrote:
> Since commit 55b48e23f5c4 ("genirq/devres: Add error handling in
> devm_request_*_irq()"), devm_request_irq() automatically logs
> detailed error messages on failure. Remove the now-redundant
> driver-specific dev_err() calls.
> 
> Signed-off-by: Pan Chuang <panchuang@xxxxxxxx>
> ---
>  drivers/hte/hte-tegra194.c | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
> 
> diff --git a/drivers/hte/hte-tegra194.c b/drivers/hte/hte-tegra194.c
> index 4a7702b32b24..e29fb105ca2d 100644
> --- a/drivers/hte/hte-tegra194.c
> +++ b/drivers/hte/hte-tegra194.c
> @@ -856,10 +856,8 @@ static int tegra_hte_probe(struct platform_device *pdev)
>  	hte_dev->hte_irq = ret;
>  	ret = devm_request_irq(dev, hte_dev->hte_irq, tegra_hte_isr, 0,
>  			       dev_name(dev), hte_dev);
> -	if (ret < 0) {
> -		dev_err(dev, "request irq failed.\n");
> +	if (ret < 0)
>  		return ret;
> -	}
>  
>  	gc->nlines = nlines;
>  	gc->ops = &g_ops;
> -- 
> 2.34.1
> 
> 

I suppose 'hte: tegra194: ' would be more appropriate, but it's the
only driver under hte anyway.

Reviewed-by: Mikko Perttunen <mperttunen@xxxxxxxxxx>