Re: [PATCH v2] intel_th: Fix MSC output device reference leak

[Guangshuo Li]

On Mon, 13 Jul 2026 at 22:02, Johan Hovold <johan@xxxxxxxxxx> wrote:
>
> On Mon, Jul 13, 2026 at 08:02:05PM +0800, Guangshuo Li wrote:
> > intel_th_output_open() looks up the output device with
> > bus_find_device_by_devt(), which returns the device with a reference that
> > must be dropped after use.
> >
> > The reference is currently intended to be dropped from
> > intel_th_output_release(). However, a successful open replaces
> > file->f_op with the output driver's file operations before returning, so
> > close runs the output driver's release method rather than
> > intel_th_output_release().
> >
> > For MSC outputs, close runs intel_th_msc_release(). That release path
> > only removes the per-file iterator and does not drop the device
> > reference taken by intel_th_output_open(), so every successful MSC open
> > leaks one device reference.
> >
> > Drop the device reference from intel_th_msc_release(), which is the
> > release path that is actually used for MSC output files.
> >
> > Fixes: 95fc36a234da ("intel_th: fix device leak on output open()")
> > Cc: stable@xxxxxxxxxxxxxxx
> > Signed-off-by: Guangshuo Li <lgs201920130244@xxxxxxxxx>
> > ---
> > v2:
> >   - Add Cc stable.
> >   - No code changes.
>
> You forgot to remove the intel_th_output_fops release callback as I
> mentioned here:
>
>         https://lore.kernel.org/all/aktZDK0NZrTdEqOm@xxxxxxxxxxxxxxxxxxxx/
>
> Johan

Sorry about that. I’ll address it in v3.

Thanks,
Guangshuo