[PATCH 56/61] staging: rtl8723bs: inline rtl8723bs_hal_xmitframe_enqueue helper

From: Arsenii Pashchenko

Date: Wed Jul 15 2026 - 09:07:04 EST


Inline the xmit frame enqueue logic from the internal CamelCase
function directly into rtw_hal_xmitframe_enqueue. This simplifies
the transmit path, removes an unnecessary layer, and cleans up
the driver code.

Signed-off-by: Arsenii Pashchenko <ulijg308@xxxxxxxxx>
---
drivers/staging/rtl8723bs/hal/hal_intf.c | 14 ++++++++++++-
.../staging/rtl8723bs/hal/rtl8723bs_xmit.c | 20 -------------------
.../staging/rtl8723bs/include/rtl8723b_xmit.h | 1 -
3 files changed, 13 insertions(+), 22 deletions(-)

diff --git a/drivers/staging/rtl8723bs/hal/hal_intf.c b/drivers/staging/rtl8723bs/hal/hal_intf.c
index a73abd36f..b11f4ab4a 100644
--- a/drivers/staging/rtl8723bs/hal/hal_intf.c
+++ b/drivers/staging/rtl8723bs/hal/hal_intf.c
@@ -202,7 +202,19 @@ u8 rtw_hal_check_ips_status(struct adapter *padapter)

int rtw_hal_xmitframe_enqueue(struct adapter *padapter, struct xmit_frame *pxmitframe)
{
- return rtl8723bs_hal_xmitframe_enqueue(padapter, pxmitframe);
+ struct xmit_priv *pxmitpriv = &padapter->xmitpriv;
+ s32 err;
+
+ err = rtw_xmitframe_enqueue(padapter, pxmitframe);
+ if (err) {
+ rtw_free_xmitframe(pxmitpriv, pxmitframe);
+
+ pxmitpriv->tx_drop++;
+ } else {
+ complete(&pxmitpriv->SdioXmitStart);
+ }
+
+ return err;
}

s32 rtw_hal_xmit(struct adapter *padapter, struct xmit_frame *pxmitframe)
diff --git a/drivers/staging/rtl8723bs/hal/rtl8723bs_xmit.c b/drivers/staging/rtl8723bs/hal/rtl8723bs_xmit.c
index e40f69c13..a4dfee1d4 100644
--- a/drivers/staging/rtl8723bs/hal/rtl8723bs_xmit.c
+++ b/drivers/staging/rtl8723bs/hal/rtl8723bs_xmit.c
@@ -496,26 +496,6 @@ s32 rtl8723bs_hal_xmit(
return false;
}

-s32 rtl8723bs_hal_xmitframe_enqueue(
- struct adapter *padapter, struct xmit_frame *pxmitframe
-)
-{
- struct xmit_priv *pxmitpriv = &padapter->xmitpriv;
- s32 err;
-
- err = rtw_xmitframe_enqueue(padapter, pxmitframe);
- if (err) {
- rtw_free_xmitframe(pxmitpriv, pxmitframe);
-
- pxmitpriv->tx_drop++;
- } else {
- complete(&pxmitpriv->SdioXmitStart);
- }
-
- return err;
-
-}
-
/*
* Return
*_SUCCESS start thread ok
diff --git a/drivers/staging/rtl8723bs/include/rtl8723b_xmit.h b/drivers/staging/rtl8723bs/include/rtl8723b_xmit.h
index ddf868c78..8d6d6d2b7 100644
--- a/drivers/staging/rtl8723bs/include/rtl8723b_xmit.h
+++ b/drivers/staging/rtl8723bs/include/rtl8723b_xmit.h
@@ -411,7 +411,6 @@ s32 rtl8723bs_init_xmit_priv(struct adapter *padapter);
void rtl8723bs_free_xmit_priv(struct adapter *padapter);
s32 rtl8723bs_hal_xmit(struct adapter *padapter, struct xmit_frame *pxmitframe);
s32 rtl8723bs_mgnt_xmit(struct adapter *padapter, struct xmit_frame *pmgntframe);
-s32 rtl8723bs_hal_xmitframe_enqueue(struct adapter *padapter, struct xmit_frame *pxmitframe);
s32 rtl8723bs_xmit_buf_handler(struct adapter *padapter);
int rtl8723bs_xmit_thread(void *context);

--
2.55.0