[PATCH 44/61] staging: rtl8723bs: remove rtw_init_hal_com_default_value
From: Arsenii Pashchenko
Date: Wed Jul 15 2026 - 09:10:38 EST
Remove the single-line function rtw_init_hal_com_default_value.
Move the AntDetection initialization directly to the main HAL
setup phase to avoid an unnecessary function call layer.
Signed-off-by: Arsenii Pashchenko <ulijg308@xxxxxxxxx>
---
drivers/staging/rtl8723bs/hal/hal_com.c | 8 --------
drivers/staging/rtl8723bs/include/hal_com.h | 1 -
drivers/staging/rtl8723bs/os_dep/os_intfs.c | 7 +++++--
3 files changed, 5 insertions(+), 11 deletions(-)
diff --git a/drivers/staging/rtl8723bs/hal/hal_com.c b/drivers/staging/rtl8723bs/hal/hal_com.c
index ca0f7d7ec..638d598e4 100644
--- a/drivers/staging/rtl8723bs/hal/hal_com.c
+++ b/drivers/staging/rtl8723bs/hal/hal_com.c
@@ -420,14 +420,6 @@ bool Hal_MappingOutPipe(struct adapter *padapter, u8 NumOutPipe)
}
-
-void rtw_init_hal_com_default_value(struct adapter *Adapter)
-{
- struct hal_com_data *pHalData = GET_HAL_DATA(Adapter);
-
- pHalData->AntDetection = 1;
-}
-
/*
* C2H event format:
* Field TRIGGER CONTENT CMD_SEQ CMD_LEN CMD_ID
diff --git a/drivers/staging/rtl8723bs/include/hal_com.h b/drivers/staging/rtl8723bs/include/hal_com.h
index a52d8318d..e6d32cf53 100644
--- a/drivers/staging/rtl8723bs/include/hal_com.h
+++ b/drivers/staging/rtl8723bs/include/hal_com.h
@@ -123,7 +123,6 @@ u8 NumOutPipe
-void rtw_init_hal_com_default_value(struct adapter *Adapter);
void c2h_evt_clear(struct adapter *adapter);
s32 c2h_evt_read_88xx(struct adapter *adapter, u8 *buf);
diff --git a/drivers/staging/rtl8723bs/os_dep/os_intfs.c b/drivers/staging/rtl8723bs/os_dep/os_intfs.c
index f31196f54..295da8c23 100644
--- a/drivers/staging/rtl8723bs/os_dep/os_intfs.c
+++ b/drivers/staging/rtl8723bs/os_dep/os_intfs.c
@@ -640,7 +640,10 @@ u8 rtw_init_drv_sw(struct adapter *padapter)
rtw_init_default_value(padapter);
- rtw_init_hal_com_default_value(padapter);
+ struct hal_com_data *pHalData = GET_HAL_DATA(padapter);
+
+ pHalData->AntDetection = 1;
+
if (rtw_init_cmd_priv(&padapter->cmdpriv))
return _FAIL;
@@ -665,7 +668,7 @@ u8 rtw_init_drv_sw(struct adapter *padapter)
spin_lock_init(&padapter->security_key_mutex);
/* We don't need to memset padapter->XXX to zero, because adapter is allocated by vzalloc(). */
- /* memset((unsigned char *)&padapter->securitypriv, 0, sizeof (struct security_priv)); */
+ /* memset((u8 *)&padapter->securitypriv, 0, sizeof (struct security_priv)); */
if (_rtw_init_sta_priv(&padapter->stapriv) == _FAIL)
goto free_recv_priv;
--
2.55.0