Re: [PATCH 0/3] counter: Remove redundant error messages on IRQ request failure

From: Joshua Crofts

Date: Wed Jul 15 2026 - 10:07:45 EST


On Wed, 15 Jul 2026 21:50:27 +0800
Pan Chuang <panchuang@xxxxxxxx> wrote:

> Commit 55b48e23f5c4 ("genirq/devres: Add error handling in
> devm_request_*_irq()") added automatic error logging to
> devm_request_threaded_irq() and devm_request_any_context_irq()
> via the new devm_request_result() helper, which prints device
> name, IRQ number, handler functions, and error code on failure.
>
> Since devm_request_irq() is a static inline wrapper around
> devm_request_threaded_irq(), it also benefits from this
> automatic logging.
>
> Remove the now-redundant dev_err() and dev_err_probe() calls
> in counter drivers that follow these devm_request_*_irq()
> functions, as the core now provides more detailed diagnostic
> information on failure.
>
> Pan Chuang (3):
> counter: stm32-timer-cnt: Remove redundant dev_err()
> counter: ti-ecap-capture: Remove redundant dev_err_probe()
> counter: ti-eqep: Remove redundant dev_err_probe()
>
> drivers/counter/stm32-timer-cnt.c | 10 ++--------
> drivers/counter/ti-ecap-capture.c | 2 +-
> drivers/counter/ti-eqep.c | 2 +-
> 3 files changed, 4 insertions(+), 10 deletions(-)
>

LGTM.

--
Kind regards

CJD