Re: [PATCH v2] PCI: rcar-gen4: Isolate driver to ARM64

From: Manivannan Sadhasivam

Date: Wed Jul 15 2026 - 10:20:01 EST


On Tue, Jul 14, 2026 at 04:10:30PM -0500, Bjorn Helgaas wrote:
> On Tue, Jul 14, 2026 at 03:19:27PM +0200, Marek Vasut wrote:
> > The driver includes linux/irqchip/arm-gic-v3.h which pulls in headers
> > which are available only on ARM and ARM64, on other architectures the
> > headers are not present and the driver fails to build. This driver is
> > used only on ARM64 hardware, isolate its build only to ARM64 to avoid
> > build failures on other architectures.
> >
> > Reported-by: kernel test robot <lkp@xxxxxxxxx>
> > Closes: https://lore.kernel.org/oe-kbuild-all/202607100310.iQw5m9Uo-lkp@xxxxxxxxx/
> > Signed-off-by: Marek Vasut <marek.vasut+renesas@xxxxxxxxxxx>
>
> Mani, I assume you'll squash this into 89bded511a66 ("PCI: rcar-gen4:
> Configure AXIINTC if iMSI-RX is not used") so it's connected to the
> addition of the linux/irqchip/arm-gic-v3.h include and there's no
> bisection hole?
>

Yes, squashed now!

- Mani

> > ---
> > Cc: "Krzysztof Wilczyński" <kwilczynski@xxxxxxxxxx>
> > Cc: Bjorn Helgaas <bhelgaas@xxxxxxxxxx>
> > Cc: Catalin Marinas <catalin.marinas@xxxxxxx>
> > Cc: Conor Dooley <conor+dt@xxxxxxxxxx>
> > Cc: Geert Uytterhoeven <geert+renesas@xxxxxxxxx>
> > Cc: Krzysztof Kozlowski <krzk+dt@xxxxxxxxxx>
> > Cc: Lorenzo Pieralisi <lpieralisi@xxxxxxxxxx>
> > Cc: Manivannan Sadhasivam <mani@xxxxxxxxxx>
> > Cc: Marc Zyngier <maz@xxxxxxxxxx>
> > Cc: Rob Herring <robh@xxxxxxxxxx>
> > Cc: Yoshihiro Shimoda <yoshihiro.shimoda.uh@xxxxxxxxxxx>
> > Cc: devicetree@xxxxxxxxxxxxxxx
> > Cc: linux-arm-kernel@xxxxxxxxxxxxxxxxxxx
> > Cc: linux-doc@xxxxxxxxxxxxxxx
> > Cc: linux-kernel@xxxxxxxxxxxxxxx
> > Cc: linux-pci@xxxxxxxxxxxxxxx
> > Cc: linux-renesas-soc@xxxxxxxxxxxxxxx
> > ---
> > V2: This is a rework of PCI: rcar-gen4: Inline GIC_TRANSLATER offset macro
> > which isolates the driver build to ARM64 via Kconfig instead:
> > https://lore.kernel.org/linux-pci/CAMuHMdVvWE7YZgKvreSn_vJLOVD4eMmn3TCGOyqSXksqjBCwvg@xxxxxxxxxxxxxx/
> > https://lore.kernel.org/linux-pci/20260714110041.GA1349622@bhelgaas/
> > ---
> > drivers/pci/controller/dwc/Kconfig | 4 ++--
> > 1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/drivers/pci/controller/dwc/Kconfig b/drivers/pci/controller/dwc/Kconfig
> > index 49a7a2c50ca15..3260d916110b2 100644
> > --- a/drivers/pci/controller/dwc/Kconfig
> > +++ b/drivers/pci/controller/dwc/Kconfig
> > @@ -346,7 +346,7 @@ config PCIE_RCAR_GEN4
> >
> > config PCIE_RCAR_GEN4_HOST
> > tristate "Renesas R-Car Gen4 PCIe controller (host mode)"
> > - depends on ARCH_RENESAS || COMPILE_TEST
> > + depends on ARM64 && (ARCH_RENESAS || COMPILE_TEST)
> > depends on PCI_MSI
> > select PCIE_DW_HOST
> > select PCIE_RCAR_GEN4
> > @@ -357,7 +357,7 @@ config PCIE_RCAR_GEN4_HOST
> >
> > config PCIE_RCAR_GEN4_EP
> > tristate "Renesas R-Car Gen4 PCIe controller (endpoint mode)"
> > - depends on ARCH_RENESAS || COMPILE_TEST
> > + depends on ARM64 && (ARCH_RENESAS || COMPILE_TEST)
> > depends on PCI_ENDPOINT
> > select PCIE_DW_EP
> > select PCIE_RCAR_GEN4
> > --
> > 2.53.0
> >

--
மணிவண்ணன் சதாசிவம்