Re: [PATCH v3] staging: rtl8723bs: remove redundant ReadChipVersion8723B wrapper

From: Greg KH

Date: Wed Jul 15 2026 - 10:35:27 EST


On Mon, Jul 13, 2026 at 10:51:56AM +0700, Arsenii Pashchenko wrote:
> Collapse the static CamelCase helper function ReadChipVersion8723B()
> directly into the main rtl8723b_read_chip_version() function.
> This removes unnecessary code nesting and cleans up the CamelCase
> naming violation in a single atomic change.
>
> Signed-off-by: Arsenii Pashchenko <ulijg308@xxxxxxxxx>
> ---
> Changes in v3:
> - Merged the previous 2-patch series into a single patch as suggested
> by Nikolay. Completely removed the redundant helper instead of
> renaming it with '__' prefixes.
>
> Changes in v2:
> - Resent the series due to submission issues with v1 (no code changes).
> ---
> drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c | 7 +------
> 1 file changed, 1 insertion(+), 6 deletions(-)

The versioning goes below the --- line that is in the diff, don't create
a new one please.

Perhaps use a tool like `b4` to handle this all for you?

thanks,

greg k-h