Re: [PATCH] USB: serial: mxuport: validate firmware header size

[Andrew Lunn]

On Wed, Jul 15, 2026 at 04:46:11PM +0800, Pengpeng Hou wrote:
> mxuport_probe() reads version bytes at fixed offsets after
> request_firmware() succeeds. Firmware loading success does not prove that
> the blob contains the whole header.
> 
> Reject blobs that do not reach the highest version byte before
> dereferencing them.
> 
> Fixes: ee467a1f2066 ("USB: serial: add Moxa UPORT 12XX/14XX/16XX driver")

Does this bother people?

https://www.kernel.org/doc/html/latest/process/stable-kernel-rules.html

I would suggest dropping the Fixes tag, unless you can point to
reports of this crashing.

> Signed-off-by: Pengpeng Hou <pengpeng@xxxxxxxxxxx>

Reviewed-by: Andrew Lunn <andrew@xxxxxxx>

    Andrew