Re: [PATCH v4 4/4] tools/build: selftests: Remove some duplicate toolchain definitions

From: Ihor Solodrai

Date: Wed Jul 15 2026 - 16:03:54 EST


On 7/15/26 7:53 AM, James Clark wrote:
> Try to remove some, but not all duplicate toolchain definitions. In
> these instances, their makefiles already include
> tools/scripts/Makefile.include which defines these in a consistent way.
>
> STRIP is the only one that was set with an '=', but I don't think it
> was significant so that difference can be dropped.
>
> Signed-off-by: James Clark <james.clark@xxxxxxxxxx>
> ---
> tools/bpf/resolve_btfids/Makefile | 3 ---
> tools/lib/api/Makefile | 4 ----
> tools/lib/subcmd/Makefile | 4 ----
> tools/lib/symbol/Makefile | 4 ----
> tools/perf/Makefile.perf | 6 ------
> tools/testing/selftests/bpf/Makefile | 1 -
> 6 files changed, 22 deletions(-)
>
> diff --git a/tools/bpf/resolve_btfids/Makefile b/tools/bpf/resolve_btfids/Makefile
> index 7672208f65e4bc245c03603634d3aa0093a91096..6fdb6302e0a28e9166175822f42cfbb4f4eb24e5 100644
> --- a/tools/bpf/resolve_btfids/Makefile
> +++ b/tools/bpf/resolve_btfids/Makefile
> @@ -20,9 +20,6 @@ HOST_OVERRIDES := AR="$(HOSTAR)" CC="$(HOSTCC)" LD="$(HOSTLD)" ARCH="$(HOSTARCH)
> CROSS_COMPILE="" CLANG_CROSS_FLAGS="" EXTRA_CFLAGS="$(HOSTCFLAGS)"
>
> RM ?= rm
> -HOSTCC ?= gcc
> -HOSTLD ?= ld
> -HOSTAR ?= ar

Acked-by: Ihor Solodrai <ihor.solodrai@xxxxxxxxx>

> HOSTPKG_CONFIG ?= pkg-config
> CROSS_COMPILE =
>
> [...]
>