Re: [PATCH v3] drm/mediatek: mtk_hdmi: Fix DDC adapter double put in v2

[CK Hu (胡俊光)]

On Mon, 2026-07-13 at 19:29 +0800, Guangshuo Li wrote:
> External email : Please do not click links or open attachments until you have verified the sender or the content.
> 
> 
> mtk_hdmi_common_probe() gets the DDC adapter with
> of_find_i2c_adapter_by_node() and registers a devm action to release the
> adapter device reference with put_device().
> 
> The HDMI v2 remove callback also calls i2c_put_adapter() on the same DDC
> adapter. This is not paired with of_find_i2c_adapter_by_node(): it drops
> the adapter device reference before the devm action drops it again, and
> it also puts a module reference that was never taken.
> 
> Remove the extra i2c_put_adapter() call and drop the now-empty HDMI v2
> remove callback. The common devm action releases the adapter device
> reference.

Reviewed-by: CK Hu <ck.hu@xxxxxxxxxxxx>

> 
> Fixes: 8d0f79886273 ("drm/mediatek: Introduce HDMI/DDC v2 for MT8195/MT8188")
> Cc: stable@xxxxxxxxxxxxxxx
> Reviewed-by: Johan Hovold <johan@xxxxxxxxxx>
> Signed-off-by: Guangshuo Li <lgs201920130244@xxxxxxxxx>
> ---
>