[PATCH 02/11] usb: common: usb-conn-gpio: Remove redundant dev_err()
From: Pan Chuang
Date: Thu Jul 30 2026 - 23:55:30 EST
Since commit 55b48e23f5c4 ("genirq/devres: Add error handling in
devm_request_*_irq()"), devm_request_threaded_irq() automatically logs
detailed error messages on failure. Remove the now-redundant
driver-specific dev_err() calls.
Signed-off-by: Pan Chuang <panchuang@xxxxxxxx>
---
drivers/usb/common/usb-conn-gpio.c | 8 ++------
1 file changed, 2 insertions(+), 6 deletions(-)
diff --git a/drivers/usb/common/usb-conn-gpio.c b/drivers/usb/common/usb-conn-gpio.c
index 421c3af38e06..f6db03d89efd 100644
--- a/drivers/usb/common/usb-conn-gpio.c
+++ b/drivers/usb/common/usb-conn-gpio.c
@@ -251,10 +251,8 @@ static int usb_conn_probe(struct platform_device *pdev)
ret = devm_request_threaded_irq(dev, info->id_irq, NULL,
usb_conn_isr, USB_CONN_IRQF,
pdev->name, info);
- if (ret < 0) {
- dev_err(dev, "failed to request ID IRQ\n");
+ if (ret < 0)
goto put_role_sw;
- }
}
if (info->vbus_gpiod) {
@@ -268,10 +266,8 @@ static int usb_conn_probe(struct platform_device *pdev)
ret = devm_request_threaded_irq(dev, info->vbus_irq, NULL,
usb_conn_isr, USB_CONN_IRQF,
pdev->name, info);
- if (ret < 0) {
- dev_err(dev, "failed to request VBUS IRQ\n");
+ if (ret < 0)
goto put_role_sw;
- }
}
platform_set_drvdata(pdev, info);
--
2.34.1