[PATCH 07/11] usb: misc: Remove redundant dev_err()/dev_err_probe()
From: Pan Chuang
Date: Thu Jul 30 2026 - 23:56:04 EST
Since commit 55b48e23f5c4 ("genirq/devres: Add error handling in
devm_request_*_irq()"),
devm_request_irq() and devm_request_threaded_irq() automatically log
detailed error messages on failure. Remove the now-redundant
driver-specific dev_err() and dev_err_probe() calls.
Signed-off-by: Pan Chuang <panchuang@xxxxxxxx>
---
drivers/usb/misc/brcmstb-usb-pinmap.c | 9 ++-------
drivers/usb/misc/qcom_eud.c | 2 +-
2 files changed, 3 insertions(+), 8 deletions(-)
diff --git a/drivers/usb/misc/brcmstb-usb-pinmap.c b/drivers/usb/misc/brcmstb-usb-pinmap.c
index 1ce885e4184c..d8e9c80a9c2e 100644
--- a/drivers/usb/misc/brcmstb-usb-pinmap.c
+++ b/drivers/usb/misc/brcmstb-usb-pinmap.c
@@ -299,10 +299,8 @@ static int __init brcmstb_usb_pinmap_probe(struct platform_device *pdev)
brcmstb_usb_pinmap_ovr_isr,
IRQF_TRIGGER_RISING,
pdev->name, pdata);
- if (err < 0) {
- dev_err(&pdev->dev, "Error requesting IRQ\n");
+ if (err < 0)
return err;
- }
}
for (x = 0, pin = pdata->in_pins; x < pdata->in_count; x++, pin++) {
@@ -317,11 +315,8 @@ static int __init brcmstb_usb_pinmap_probe(struct platform_device *pdev)
IRQF_SHARED | IRQF_TRIGGER_RISING |
IRQF_TRIGGER_FALLING,
pdev->name, pin);
- if (err < 0) {
- dev_err(&pdev->dev, "Error requesting IRQ for %s pin\n",
- pin->name);
+ if (err < 0)
return err;
- }
}
dev_dbg(&pdev->dev, "Driver probe succeeded\n");
diff --git a/drivers/usb/misc/qcom_eud.c b/drivers/usb/misc/qcom_eud.c
index 926419ca560f..a7b9ed4ac071 100644
--- a/drivers/usb/misc/qcom_eud.c
+++ b/drivers/usb/misc/qcom_eud.c
@@ -225,7 +225,7 @@ static int eud_probe(struct platform_device *pdev)
ret = devm_request_threaded_irq(&pdev->dev, chip->irq, handle_eud_irq,
handle_eud_irq_thread, IRQF_ONESHOT, NULL, chip);
if (ret)
- return dev_err_probe(chip->dev, ret, "failed to allocate irq\n");
+ return ret;
enable_irq_wake(chip->irq);
--
2.34.1