Re: [PATCH v3] x86/kaslr: Remove two redundant if checks

From: Borislav Petkov

Date: Sun Aug 02 2026 - 13:24:41 EST


On Sun, Aug 02, 2026 at 11:35:30AM +0200, Thorsten Blum wrote:
> added the *output != random_addr check because add_identity_map() was
> only needed when the physical address changed.

The check is there to update *output in case a new random address has been
generated.

add_identity_map() was simply called to make sure that the new address is
mapped in the page table.

Are you sure you understand the code you're touching?

--
Regards/Gruss,
Boris.

https://people.kernel.org/tglx/notes-about-netiquette