Re: [PATCH v3] x86/kaslr: Remove two redundant if checks
From: Thorsten Blum
Date: Sun Aug 02 2026 - 19:42:41 EST
On Sun, Aug 02, 2026 at 10:24:02AM -0700, Borislav Petkov wrote:
> On Sun, Aug 02, 2026 at 11:35:30AM +0200, Thorsten Blum wrote:
> > added the *output != random_addr check because add_identity_map() was
> > only needed when the physical address changed.
>
> The check is there to update *output in case a new random address has been
> generated.
>
> add_identity_map() was simply called to make sure that the new address is
> mapped in the page table.
>
> Are you sure you understand the code you're touching?
Are you objecting to the reasoning in the commit message, or to removing
the if check itself?