Re: [PATCH v4 04/21] pinctrl: starfive: Add StarFive JHB100 sys0 controller driver

[Linus Walleij]

Hi Changhuang,

On Sat, Aug 1, 2026 at 9:27 AM Changhuang Liang
<changhuang.liang@xxxxxxxxxxxxxxxx> wrote:

> Add pinctrl driver for StarFive JHB100 SoC System-0(sys0) pinctrl
> controller.
>
> Simultaneously add a generic pinctrl driver framework for registering
> the pinctrl of other domains (sys1, sys2, and so on) in the JHB100 SoC.
>
> Co-developed-by: Lianfeng Ouyang <lianfeng.ouyang@xxxxxxxxxxxxxxxx>
> Signed-off-by: Lianfeng Ouyang <lianfeng.ouyang@xxxxxxxxxxxxxxxx>
> Signed-off-by: Alex Soo <yuklin.soo@xxxxxxxxxxxxxxxx>
> Signed-off-by: Changhuang Liang <changhuang.liang@xxxxxxxxxxxxxxxx>

With Uwe's and Philipp's comments addressed this looks very nice.
I really like how you use all helper libraries in this driver!

Once DT bindings and comments are accepted, this can be merged.

Yours,
Linus Walleij