Re: [PATCH v2 2/4] dt-bindings: display: rockchip,lvds: add RK3568

[Rob Herring]

On Fri, Jul 24, 2026 at 10:08:22AM +0200, Rok Markovic wrote:
> The RK3568 LVDS transmitter has no register block of its own: it is
> programmed entirely through the GRF and re-uses the MIPI DSI0 D-PHY
> (rockchip,rk3568-dsi-dphy) in LVDS mode. It therefore takes the same
> shape as px30: phys/phy-names, no reg, and no clock of its own.
> 
> Since the block exposes no MMIO, nothing in the LVDS path is clocked
> from the DSI controller's APB clock; that gate is held off while LVDS
> scans out. It has no analog supplies of its own and no pinctrl either:
> the lanes are dedicated D-PHY pins, not muxable GPIOs.
> 
> Signed-off-by: Rok Markovic <rok@xxxxxxxxxxx>
> Assisted-by: Claude:claude-opus-4-8
> ---
> Changes in v2:
>   - RK3568 now takes no clock (clocks/clock-names disabled, as for
>     px30): the block has no register space, so nothing consumes the
>     DSI controller's APB clock.
> 
>  .../display/rockchip/rockchip,lvds.yaml       | 22 +++++++++++++++++++
>  1 file changed, 22 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/display/rockchip/rockchip,lvds.yaml b/Documentation/devicetree/bindings/display/rockchip/rockchip,lvds.yaml
> index 03b002a..b77d4fa 100644
> --- a/Documentation/devicetree/bindings/display/rockchip/rockchip,lvds.yaml
> +++ b/Documentation/devicetree/bindings/display/rockchip/rockchip,lvds.yaml
> @@ -15,6 +15,7 @@ properties:
>      enum:
>        - rockchip,px30-lvds
>        - rockchip,rk3288-lvds
> +      - rockchip,rk3568-lvds
>  
>    reg:
>      maxItems: 1
> @@ -121,6 +122,27 @@ allOf:
>          - avdd1v8-supply
>          - avdd3v3-supply
>  
> +  - if:
> +      properties:
> +        compatible:
> +          contains:
> +            const: rockchip,rk3568-lvds
> +
> +    then:
> +      properties:
> +        reg: false
> +        clocks: false
> +        clock-names: false
> +        avdd1v0-supply: false
> +        avdd1v8-supply: false
> +        avdd3v3-supply: false
> +        pinctrl-names: false
> +        pinctrl-0: false

Other than pinctrl props, this is the same as the existing px30 if/then 
schema, so just add the compatible there. pinctrl properties are 
implicitly always allowed.

Really, I think this and px30 and this should be its own schema. There's 
not a lot of common parts.

Finally, if the only interface is the GRF, then this should be a child 
of the GRF node.

Rob