Re: [PATCH sysctl-next 2/2] sysctl: remove redundant CONFIG_PROC_FS checks

From: Oleg Nesterov

Date: Mon Aug 10 2026 - 08:17:48 EST


Hi Joel,

On 08/10, Joel Granados wrote:
>
> On Fri, Aug 07, 2026 at 05:48:11PM +0200, Oleg Nesterov wrote:
> > --- a/drivers/parport/procfs.c
> > +++ b/drivers/parport/procfs.c
> > @@ -26,9 +26,9 @@
> >
> > #include <linux/uaccess.h>
> >
> > -#if defined(CONFIG_SYSCTL) && defined(CONFIG_PROC_FS)
> > +#ifdef CONFIG_SYSCTL
> >
> > -#define PARPORT_MIN_TIMESLICE_VALUE 1ul
> > +#define PARPORT_MIN_TIMESLICE_VALUE 1ul
>
> Nit: Please remove the formatting changes from the series.

Hmm. I replaced "#if defined(CONFIG_SYSCTL)" with "#ifdef CONFIG_SYSCTL"
because the latter matches the rest of this file which uses "#ifdef", not
"#if defined(...)" elsewhere...

Plus I removed the extra whitespace after eol in the next line.

What exactly you want me to revert in this cleanup?

In any case, I'd be happy to send V2. But I am travelling without
my work laptop, I can only do this when I return on Aug 19.

Thanks!

Oleg.