Re: [PATCH sysctl-next 2/2] sysctl: remove redundant CONFIG_PROC_FS checks
From: Joel Granados
Date: Tue Aug 11 2026 - 08:53:43 EST
On Mon, Aug 10, 2026 at 02:07:33PM +0200, Oleg Nesterov wrote:
> Hi Joel,
>
> On 08/10, Joel Granados wrote:
> >
> > On Fri, Aug 07, 2026 at 05:48:11PM +0200, Oleg Nesterov wrote:
> > > --- a/drivers/parport/procfs.c
> > > +++ b/drivers/parport/procfs.c
> > > @@ -26,9 +26,9 @@
> > >
> > > #include <linux/uaccess.h>
> > >
> > > -#if defined(CONFIG_SYSCTL) && defined(CONFIG_PROC_FS)
> > > +#ifdef CONFIG_SYSCTL
> > >
> > > -#define PARPORT_MIN_TIMESLICE_VALUE 1ul
> > > +#define PARPORT_MIN_TIMESLICE_VALUE 1ul
> >
> > Nit: Please remove the formatting changes from the series.
>
> Hmm. I replaced "#if defined(CONFIG_SYSCTL)" with "#ifdef CONFIG_SYSCTL"
> because the latter matches the rest of this file which uses "#ifdef", not
> "#if defined(...)" elsewhere...
>
> Plus I removed the extra whitespace after eol in the next line.
Im referring to the white space.
Attachment:
signature.asc
Description: PGP signature