Re: [PATCH] net: calxeda: xgmac: Fix use-after-free in xgmac_remove due to race condition
From: Jakub Kicinski
Date: Tue Aug 11 2026 - 11:03:17 EST
On Tue, 11 Aug 2026 09:33:42 +0800 Pei Xiao wrote:
> 在 2026/8/11 05:43, Jakub Kicinski 写道:
> > On Tue, 4 Aug 2026 10:21:26 +0800 Pei Xiao wrote:
> >> In xgmac_probe, &priv->tx_timeout_work is bound with
> >> xgmac_tx_timeout_work, and xgmac_interrupt and xgmac_tx_timeout can
> >> both schedule this work on system_wq.
> >
> > AI reviewer reports that this can add a deadlock.
> >
> > Looks like we're trading one bug for another.
> >
> > If you don't have access to this HW or ability to test your patches
> > in general - please don't try to send such superficial fixes.
> Sorry for making noise. Does this issue exist, and does it need to be
> fixed? If it needs to be fixed, I'd like to learn how it ends up being fixed
Your 3 recent submissions were all inadequate. Please leave networking
drivers be. It will take us more time to review your code than fix
these. And you're touching drivers which nobody worked on for
_15 years_!