Re: [PATCH] net: calxeda: xgmac: Fix use-after-free in xgmac_remove due to race condition

From: Pei Xiao

Date: Mon Aug 10 2026 - 21:34:17 EST




在 2026/8/11 05:43, Jakub Kicinski 写道:
> On Tue, 4 Aug 2026 10:21:26 +0800 Pei Xiao wrote:
>> In xgmac_probe, &priv->tx_timeout_work is bound with
>> xgmac_tx_timeout_work, and xgmac_interrupt and xgmac_tx_timeout can
>> both schedule this work on system_wq.
>
> AI reviewer reports that this can add a deadlock.
>
> Looks like we're trading one bug for another.
>
> If you don't have access to this HW or ability to test your patches
> in general - please don't try to send such superficial fixes.
Sorry for making noise. Does this issue exist, and does it need to be
fixed? If it needs to be fixed, I'd like to learn how it ends up being fixed

Pei.
Thanks.