Re: [PATCH v2 2/3] KVM: TDX: Fix the exit reason handling
From: Edgecombe, Rick P
Date: Tue Aug 11 2026 - 11:23:31 EST
On Tue, 2026-08-11 at 09:32 +0800, Xiaoyao Li wrote:
> > We could make this return instead be a goto err; that returns this. Bonus is
> > the
> > comment on the other one can cover them both. What do you think?
>
> Given 1) this patch is here mainly to avoid the false-positive on
> bus_lock_detected after the next patch,
Hmm. Before this patch these are just one line returns. So a "goto err" would be
unneeded. After this single line is expanded to be something more elaborate, and
a comment is added around one of these more elaborate returns, but not the
other. So I consider it a bit of a style regression. Which makes it appropriate
to adjust it in the patch IMO.
> 2) the whole series is targeted
> for stable kernels, and 3) this part will change as suggested by [1]
This is true.
>
> I think we can just leave it as-is to make the change as simple as possible.
>
> [1] https://lore.kernel.org/all/anXxBzO41_5eaaOI@xxxxxxxxxx/