Re: [PATCH v9 2/5] phy: qualcomm: hdmi-28lpm: provide dynamic configuration

[Dmitry Baryshkov]

On Wed, Aug 12, 2026 at 03:51:16PM +0200, Manivannan Sadhasivam wrote:
> On Wed, May 13, 2026 at 09:14:05PM +0300, Dmitry Baryshkov wrote:
> > Replace fixed value configuration tables with the values calculated at
> > the runtime. In some cases the values might differ from the original
> > values. Those were validated on the IFC6410 board.
> > 
> > Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@xxxxxxxxxxxxxxxx>
> 
> One nit below. With that fixed,
> 
> Acked-by: Manivannan Sadhasivam <manivannan.sadhasivam@xxxxxxxxxxxxxxxx>
> 
> > ---
> >  drivers/phy/qualcomm/phy-qcom-hdmi-28lpm.c | 325 +++++++++--------------------
> >  1 file changed, 104 insertions(+), 221 deletions(-)
> > 
> > -static const struct pll_rate *qcom_hdmi_8960_pll_find_rate(unsigned long rate)
> > +static inline void write16(u16 val, void __iomem *reg)
> 
> No 'inline' keyword in .c files please.

Why?

> 
> - Mani
> 
> -- 
> மணிவண்ணன் சதாசிவம்

-- 
With best wishes
Dmitry