Re: [PATCH v3 1/3] dt-bindings: clock: qcom: Move x1e80100 TCSR to own binding

[Krzysztof Kozlowski]

On 13/08/2026 08:55, Qiang Yu wrote:
>>> +required:
>>> +  - compatible
>>> +  - clocks
>>> +  - '#clock-cells'
>>> +  - '#reset-cells'
>>
>> This is unexplained ABI change. When you are asked, you need to address
>> feedback from LLM, not blindly implement it without checking its
>> validity.
>>
> After adding these two properties to the required list, I ran a dtb
> check and saw no related errors or warnings. But I overlooked one
> thing: my dtb check was against the current tree only. This change
> could make dtb checks fail for historical TCSR DT nodes that did not
> have these two properties. So to be safe, I don't think they should be
> added to the required list.

Did you change the driver code to fail when DTS is not having these?


Best regards,
Krzysztof