Re: [PATCH v14 03/22] KVM: selftests: Initialize the TDX VM
From: Edgecombe, Rick P
Date: Thu Aug 13 2026 - 19:42:05 EST
On Thu, 2026-07-23 at 16:44 +0800, Xiaoyao Li wrote:
> > + init_vm->attributes = attributes;
>
> Besides CPUID, it only allows attributes to be configure but leave XFAM
> as 0. I think the changelog needs to explain why we need to configure
> attributes.
>
> The rest of the patch looks good to me.
How about directly setting xfam to zero for clarity?