Re: [PATCH v14 03/22] KVM: selftests: Initialize the TDX VM
From: Xiaoyao Li
Date: Sat Aug 15 2026 - 05:18:41 EST
On 8/14/2026 7:41 AM, Edgecombe, Rick P wrote:
On Thu, 2026-07-23 at 16:44 +0800, Xiaoyao Li wrote:
+ init_vm->attributes = attributes;
Besides CPUID, it only allows attributes to be configure but leave XFAM
as 0. I think the changelog needs to explain why we need to configure
attributes.
The rest of the patch looks good to me.
How about directly setting xfam to zero for clarity?
Agreed. It's simple.