Re: [PATCH v2] HID: core: demote warning to debug level

[Benjamin Tissoires]

On Aug 24 2026, Lee Jones wrote:
> On Wed, 10 Jun 2026, Jiri Kosina wrote:
> 
> > On Sat, 23 May 2026, Matteo Croce wrote:
> > 
> > > From: Matteo Croce <teknoraver@xxxxxxxx>
> > > 
> > > The log level for short  messages was changed from debug to warning,
> > > flooding syslog on systems with devices that regularly send
> > > short reports, in my case an UPS:
> > > 
> > >     $ dmesg |grep -c 'Event data for report .* was too short'
> > >     35
> > > 
> > > Demote it back to debug level.
> > > 
> > > Fixes: 0a3fe972a7cb ("HID: core: Mitigate potential OOB by removing bogus memset()")
> > > Signed-off-by: Matteo Croce <teknoraver@xxxxxxxx>
> > 
> > Applied, thanks.
> 
> FWIW, I'd like to contest this patch.
> 
> The warning is real.  It means that the HID report was rejected and as
> such something on the system will be now be non-functional.  Silencing
> the warning is not helpful.  It does not fix the issue, and now the user
> / admin has no idea that its even happening.
> 
> This warning has caught a bunch of genuine issues related to testing
> infrastructure and incorrectly coded firmware that have subsequently
> been rectified.
> 
> Please don't hide this issue.  Fix the root cause instead.

Please have a look at the actual code in the tree first. That patch was
applied by Jiri, yes, but IIRC it was dropped in a merge commit and is
not included in any trees AFAICT.

Cheers,
Benjamin