Re: [PATCH net-next v7 3/3] dpll: add SiTime SiT9531x DPLL clock driver
From: Ali Rouhi
Date: Tue Aug 25 2026 - 17:56:03 EST
On 25/08/2026 11:00, Jiri Pirko wrote:
> It's a new driver. Linear review in one hunk. I think it is better that
> way as you see the whole thing right away.
Jiri, Vadim, Ivan - the reviews point in opposite directions, so I would
rather ask than guess.
Vadim asked for a split. Ivan agreed with him, suggested low-level ops,
then core ops, then features one by one, and pointed at the zl3073x git
history as the example to follow. I agreed to that, and the plan for v8
was 13 patches on that shape, each building and working on its own, with
the end state identical to v7. Jiri would rather it stayed one patch.
The breakdown is in my reply of 21 August, in case it did not reach your
mailbox:
https://lore.kernel.org/netdev/20260821010556.95192-1-arouhi@xxxxxxxxxx/
Tell me which you would rather have and I will do that. My default is to
go ahead with the split.
Thanks,
Ali