Re: [PATCH net-next v7 3/3] dpll: add SiTime SiT9531x DPLL clock driver
From: Jiri Pirko
Date: Thu Aug 27 2026 - 13:13:20 EST
Tue, Aug 25, 2026 at 11:55:24PM +0200, arouhi@xxxxxxxxxx wrote:
>On 25/08/2026 11:00, Jiri Pirko wrote:
>> It's a new driver. Linear review in one hunk. I think it is better that
>> way as you see the whole thing right away.
>
>Jiri, Vadim, Ivan - the reviews point in opposite directions, so I would
>rather ask than guess.
>
>Vadim asked for a split. Ivan agreed with him, suggested low-level ops,
>then core ops, then features one by one, and pointed at the zl3073x git
>history as the example to follow. I agreed to that, and the plan for v8
>was 13 patches on that shape, each building and working on its own, with
>the end state identical to v7. Jiri would rather it stayed one patch.
I don't care that much.
>
>The breakdown is in my reply of 21 August, in case it did not reach your
>mailbox:
>
>https://lore.kernel.org/netdev/20260821010556.95192-1-arouhi@xxxxxxxxxx/
>
>Tell me which you would rather have and I will do that. My default is to
>go ahead with the split.
>
>Thanks,
>Ali
>This email message and any attachments are for the sole use of the intended recipient and contain proprietary and/or confidential information that may be privileged or otherwise protected from disclosure. Any unauthorized review, use, disclosure, copying or distribution of the information included in this message and any attachment is prohibited and may be unlawful. If you are not an intended recipient, please contact the sender by reply email and permanently delete and destroy the original message and any attachments, and any printouts or copies of the message and attachments to the original message. Thank you.