Re: [PATCH v3 2/3] nfc: st-nci: add raw NCI path for ST21NFCD

[Krzysztof Kozlowski]

On Thu, Aug 20, 2026 at 08:56:10PM +0000, Kristian Brox wrote:
>  static const struct i2c_device_id st_nci_i2c_id_table[] = {
> -	{ .name = ST_NCI_DRIVER_NAME },
> -	{ }
> +	{ ST_NCI_DRIVER_NAME },
> +	{}
>  };
>  MODULE_DEVICE_TABLE(i2c, st_nci_i2c_id_table);
>  
> -static const struct acpi_device_id st_nci_i2c_acpi_match[] = {
> -	{ .id = "SMO2101" },
> -	{ .id = "SMO2102" },
> -	{ }
> +static const struct acpi_device_id st_nci_i2c_acpi_match[] __maybe_unused = {
> +	{"SMO2101"},
> +	{"SMO2102"},

Odd. Previous code was correct, this is not.

What are you doing here?

> +	{}
>  };
>  MODULE_DEVICE_TABLE(acpi, st_nci_i2c_acpi_match);
>  
> -static const struct of_device_id of_st_nci_i2c_match[] = {
> -	{ .compatible = "st,st21nfcb-i2c" },
> -	{ .compatible = "st,st21nfcb_i2c" },
> -	{ .compatible = "st,st21nfcc-i2c" },
> -	{ }
> +static const struct of_device_id of_st_nci_i2c_match[] __maybe_unused = {
> +	{ .compatible = "st,st21nfcb-i2c", },
> +	{ .compatible = "st,st21nfcb_i2c", },

Why do you change the order of these entries?

> +	{ .compatible = "st,st21nfcc-i2c", },
> +	{ .compatible = "st,st21nfcd",
> +	  .data = (void *)ST_NCI_I2C_PROTO_RAW_NCI },
> +	{}

Best regards,
Krzysztof