Re: [PATCH 1/3] usb: ehci: support controllers with non-standard registers

[Alan Stern]

On Mon, Aug 31, 2026 at 12:24:19AM +0200, Linus Walleij wrote:
> The Faraday FOTG210 EHCI implementation moves PORTSC, omits
> CONFIGFLAG and USBMODE, and needs controller-specific speed and reset
> handling. Add
> per-controller hooks for those variations while preserving the standard
> register path for existing drivers.
> 
> Also allow a controller to reject full/low-speed isochronous transfers
> when its integrated transaction translator cannot schedule siTDs.
> 
> Assisted-by: LLM

Which LLM?  Or is that the actual name?

> Signed-off-by: Linus Walleij <linusw@xxxxxxxxxx>
> ---

This is a pretty unwieldy patch, which makes it a little difficult to
review.  Can you split it into, say, three parts?  Such as: one for
the port status register change, one for the port reset and speed change,
and one for everything else?

Overall it looks okay; it's just hard to check the details.

Alan Stern