Re: [PATCH 1/3] usb: ehci: support controllers with non-standard registers
From: Linus Walleij
Date: Mon Aug 31 2026 - 04:04:51 EST
On Mon, Aug 31, 2026 at 3:15 AM Alan Stern <stern@xxxxxxxxxxxxxxxxxxx> wrote:
> On Mon, Aug 31, 2026 at 12:24:19AM +0200, Linus Walleij wrote:
> > The Faraday FOTG210 EHCI implementation moves PORTSC, omits
> > CONFIGFLAG and USBMODE, and needs controller-specific speed and reset
> > handling. Add
> > per-controller hooks for those variations while preserving the standard
> > register path for existing drivers.
> >
> > Also allow a controller to reject full/low-speed isochronous transfers
> > when its integrated transaction translator cannot schedule siTDs.
> >
> > Assisted-by: LLM
>
> Which LLM? Or is that the actual name?
The new kernel policy is to just say "LLM"
Documentation/process/coding-assistants.rst
commit 816d9992d9ed434ec52cfbd63080d518e535a41b
"coding-assistants: simplify attribution"
...but it is GPT 5.6!
> This is a pretty unwieldy patch, which makes it a little difficult to
> review. Can you split it into, say, three parts? Such as: one for
> the port status register change, one for the port reset and speed change,
> and one for everything else?
Of course, no problem.
Yours,
Linus Walleij