Re: [PATCH v3 3/3] arm64: dts: qcom: shikra: Update rpm-stats compatible to SoC specific

[Bjorn Andersson]

On Mon, Jul 13, 2026 at 01:46:56PM +0530, Sneh Mankad wrote:
> A generic "qcom,rpm-stats" compatible only reads stats for SoC level LPM
> stats like vmin and vlow.
> 
> Shikra SoC specific compatible allows reading individual subsystem level
> LPM stats along with SoC level LPM stats. Change it.
> 
> Keep "qcom,rpm-stats" as fallback compatible.

So the fallback compatible works, but the more specific compatible gives
you additional stats?

If that interpretation is correct then this patch is correct.

But then you need to fix the binding.

Regards,
Bjorn

> 
> Reviewed-by: Konrad Dybcio <konrad.dybcio@xxxxxxxxxxxxxxxx>
> Signed-off-by: Sneh Mankad <sneh.mankad@xxxxxxxxxxxxxxxx>
> ---
>  arch/arm64/boot/dts/qcom/shikra.dtsi | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/arm64/boot/dts/qcom/shikra.dtsi b/arch/arm64/boot/dts/qcom/shikra.dtsi
> index 4e5bc9e17c8ed8914733ac9fdc9b69128b40216e..b299f316e3c61858c4b380f6211d0f36ef9fecf9 100644
> --- a/arch/arm64/boot/dts/qcom/shikra.dtsi
> +++ b/arch/arm64/boot/dts/qcom/shikra.dtsi
> @@ -535,7 +535,7 @@ apss_mpm: sram@1b8 {
>  		};
>  
>  		sram@4690000 {
> -			compatible = "qcom,rpm-stats";
> +			compatible = "qcom,shikra-rpm-stats", "qcom,rpm-stats";
>  			reg = <0x0 0x04690000 0x0 0x14000>;
>  		};
>  
> 
> -- 
> 2.34.1
>