Re: [PATCH v2] ARM: dts: samsung: exynos4210-i9100: Enable RTS/CTS in Bluetooth node

[Paul Cercueil]

Hi Marek,

Le mercredi 02 septembre 2026 à 10:36 +0200, Marek Szyprowski a écrit :
> On 29.08.2026 12:15, Paul Cercueil wrote:
> > The BCM4330 is connected using CTS/RTS too, so add the 'uart-has-
> > rtscts'
> > property.
> > 
> > Signed-off-by: Paul Cercueil <paul@xxxxxxxxxxxxxxx>
> 
> 
> Indeed the CTS/RTS pins are used for BT on most of the ARM Exynos
> boards,
> as the "<&uartX_fctl>" property is assigned for pinctl-0. This is not
> really
> specific to i9100, so maybe this property should be added to other
> dts?

I can add it to all exynos4 boards that use the "uartX_fctl" property.


> However I wonder if Samsung UART driver actually use this "uart-has-
> rtscts"
> DT property? A quick "git grep uart-has-rtscts drivers/tty" shows
> nothing
> related to Samsung Exynos...

It looks like it does not. I still think the DT property should be here
but I won't fight over this.

Cheers,
-Paul

> 
> > ---
> > 
> > Notes:
> >     Changes:
> >     
> >     V1 was: "ARM: dts: samsung: exynos4210-i9100: Fix Bluetooth
> > node"
> >     
> >     -v2: Drop max-speed property. It's only supposed to be used in
> > some
> >          cases, which don't apply here. As this was the "fix" for
> > getting
> >          Bluetooth to work on my device, which will be applied to
> > the
> >          driver instead, the Fixes: tag was removed.
> > 
> >  arch/arm/boot/dts/samsung/exynos4210-i9100.dts | 1 +
> >  1 file changed, 1 insertion(+)
> > 
> > diff --git a/arch/arm/boot/dts/samsung/exynos4210-i9100.dts
> > b/arch/arm/boot/dts/samsung/exynos4210-i9100.dts
> > index 8a635bee59fa..95964be7daa8 100644
> > --- a/arch/arm/boot/dts/samsung/exynos4210-i9100.dts
> > +++ b/arch/arm/boot/dts/samsung/exynos4210-i9100.dts
> > @@ -875,6 +875,7 @@ &serial_0 {
> >  	status = "okay";
> >  
> >  	pinctrl-names = "default";
> > +	uart-has-rtscts;
> >  	pinctrl-0 = <&bt_en>, <&bt_res>, <&uart0_data>,
> > <&uart0_fctl>;
> >  
> >  	bluetooth {
> 
> Best regards