Re: [PATCH 2/5] dt-bindings: media: qcom,maili-iris: Add maili video codec binding

[Krzysztof Kozlowski]

On Mon, Sep 14, 2026 at 09:00:25PM +0800, Wangao Wang wrote:
> +
> +maintainers:
> +  - Vikash Garodia <vikash.garodia@xxxxxxxxxxxxxxxx>
> +  - Dikshita Agarwal <dikshita.agarwal@xxxxxxxxxxxxxxxx>
> +

A nit, subject: drop second/last, redundant "binding". The
"dt-bindings" prefix is already stating that these are bindings.
See also:
https://elixir.bootlin.com/linux/v7.1-rc7/source/Documentation/devicetree/bindings/submitting-patches.rst#L23

> +description:
> +  The Iris video processing unit on Qualcomm Maili SoC is a video encode and
> +  decode accelerator.
> +
> +properties:
> +  compatible:
> +    enum:
> +      - qcom,maili-iris
> +
> +  reg:
> +    maxItems: 1
> +
> +  interrupts:
> +    maxItems: 1
> +
> +  clocks:
> +    maxItems: 8
> +
> +  clock-names:
> +    items:
> +      - const: iface
> +      - const: core
> +      - const: vcodec0_core
> +      - const: iface1
> +      - const: core_freerun
> +      - const: vcodec0_core_freerun
> +      - const: vcodec_bse

bse? What does vcodec stand for? Isn't Iris a vcodec?

> +      - const: vcodec_vpp0

cpp?

> +
> +  firmware-name:
> +    maxItems: 1
> +
> +  interconnects:
> +    maxItems: 2
> +
> +  interconnect-names:
> +    items:
> +      - const: cpu-cfg
> +      - const: video-mem
> +
> +  power-domains:
> +    maxItems: 5
> +
> +  power-domain-names:
> +    items:
> +      - const: venus
> +      - const: vcodec0
> +      - const: mxc
> +      - const: mmcx
> +      - const: vpp0
> +
> +  resets:
> +    maxItems: 4
> +
> +  reset-names:
> +    items:
> +      - const: bus0
> +      - const: bus1
> +      - const: core
> +      - const: vcodec0_core
> +
> +  iommus:
> +    maxItems: 4
> +
> +  dma-coherent: true
> +
> +  memory-region:
> +    minItems: 1

Why is this flexible?

> +    items:
> +      - description: Firmware-loaded codec carveout
> +      - description: IOMMU IOVA reservation region
> +
> +  operating-points-v2: true

Best regards,
Krzysztof