Re: [PATCH v6 00/13] syscalls: Add a shared table for all archs

From: Arnd Bergmann

Date: Thu Sep 17 2026 - 01:56:34 EST


On Thu, Sep 17, 2026, at 00:19, André Almeida wrote:
> Em 15/09/2026 04:45, Arnd Bergmann escreveu:
>> On Sat, Aug 29, 2026, at 01:19, André Almeida wrote:
>
> Thanks for testing! I believe I found a simple solution for this. I
> modified syscall_o32.tbl and can confirm it triggers a rebuild now:
>
> diff --git a/arch/mips/kernel/syscalls/Makefile
> b/arch/mips/kernel/syscalls/Makefile
> index aaa5443ea906..9e31d1ce5015 100644
> --- a/arch/mips/kernel/syscalls/Makefile
> +++ b/arch/mips/kernel/syscalls/Makefile
> @@ -40,10 +40,10 @@ src_n32 := $(src)/syscall_n.tbl
> src_n64 := $(src)/syscall_n.tbl
> src_o32 := $(src)/syscall_o32.tbl
>
> -$(kapi)/unistd_nr_%.h: $(systbl_common) $(sysnr) FORCE
> +$(kapi)/unistd_nr_%.h: $(systbl_common) $(src_%) $(sysnr) FORCE
> $(call if_changed,sysnr)
>
> -$(kapi)/syscall_table_%.h: $(systbl) $(systbl_common) FORCE
> +$(kapi)/syscall_table_%.h: $(systbl) $(systbl_common) $(src_%) FORCE
> $(call if_changed,systbl)

I had tried the same thing already, but in my testing, it did
not rebuild after changing the syscall_n.tbl file, only the
syscall_o32.tbl file. Can you verify that your change rebuilds
all nine files in the correct cases?

>> The rt_sigtimedwait and ustat entries had a typo that caused a link
>> error, but I did not check if there were any additional mistakes that
>> caused incorrect output data without causing a link failure.
>>
>
> Ops, my bad. I had another round comparing the tables, and I found
> another case that needed a fix:
>
> diff --git a/arch/mips/kernel/syscalls/syscall_n.tbl
> b/arch/mips/kernel/syscalls/syscall_n.tbl
> index e3d278f715b7..1882527053af 100644
> --- a/arch/mips/kernel/syscalls/syscall_n.tbl
> +++ b/arch/mips/kernel/syscalls/syscall_n.tbl
> @@ -43,7 +43,7 @@
> 33 common pause sys_pause
> 34 common nanosleep sys_nanosleep
> sys_nanosleep_time32
> 35 common getitimer sys_getitimer
> compat_sys_getitimer
> -36 common setitimer sys_setitimer
> compat_setitimer
> +36 common setitimer sys_setitimer
> compat_sys_setitimer
> 37 common alarm sys_alarm
> 38 common getpid sys_getpid
> 39 common sendfile sys_sendfile64
> compat_sys_sendfile

Looks good, thanks for checking this one.

Arnd